Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diffmah packaging to pyproject.toml #109

Merged
merged 12 commits into from
Sep 26, 2023
Merged

Update diffmah packaging to pyproject.toml #109

merged 12 commits into from
Sep 26, 2023

Conversation

aphearin
Copy link
Contributor

  • Update installation requirement to python>=3.9
  • Update packaging structure to pyproject.toml
  • Remove diffmah/_version.py and switch to dynamic versioning

@aphearin
Copy link
Contributor Author

@beckermr I think I got this right but this is the last release I'd like to do before the first Diffsky mocks that use this repo and so I figured I'd check to see if anything jumps out you.

@aphearin aphearin requested a review from beckermr September 26, 2023 16:32
@beckermr
Copy link
Collaborator

Nothing jumps out. You might add some tests like I do here to be sure: https://github.com/regro/conda-forge-metadata/blob/main/.github/workflows/tests.yml#L39

@aphearin
Copy link
Contributor Author

Hmmm @beckermr looks like I made some some kind of naive copypasta mistake in this commit.

@beckermr
Copy link
Collaborator

Change the checkout depth to get the full repo and not just the latest commit.

@beckermr
Copy link
Collaborator

Hmmmmm I'll need to debug locally to figure this out.

@beckermr
Copy link
Collaborator

OK @aphearin fixed - needed some deps that were missing

@aphearin
Copy link
Contributor Author

Great - thanks for the help @beckermr!

@aphearin aphearin merged commit 2f585dd into main Sep 26, 2023
3 checks passed
@aphearin aphearin deleted the pyproject branch September 26, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants